Homesource Forums

Homeworld Source Editing Talk
It is currently Fri Mar 24, 2017 10:57 pm

All times are UTC - 5 hours




Post new topic Reply to topic  [ 6 posts ] 
Author Message
 Post subject: r 493
PostPosted: Thu Feb 22, 2007 6:54 am 
Offline
coder

Joined: Tue Nov 07, 2006 4:40 am
Posts: 236
Seems this commit breaks the savegame.

I'll see what's causing it......

Aunxx.


Top
 Profile  
 
 Post subject:
PostPosted: Thu Feb 22, 2007 8:13 am 
Offline
Site Admin
User avatar

Joined: Tue Dec 14, 2004 12:41 am
Posts: 326
Moved this from the bug #28 thread...

aunxx wrote:
Hmmm.
Can anyone else save and the reload the game in Mission 3 as it crashes for me now.
Or any level....... :shock: :shock: :shock:


EDIT: Confirmed. Linux games saved under rev 493 crash on loading.

Hmmm... A suggested list of tests for any commit may be in order, perhaps?

1) Loads past saved games.
2) Saves and loads current games.
3) Plays a NIS. NIS 3, at least, as this is the one with the most happening and has caused the most problems in the past.
4) Test combat.

Anything else that's really needed? Testing every function for every commit is a bit much, but is there anything else we want to say "you should test this before commiting"?

A somewhat deeper level of testing would include the tutorials and all special functions.

We could also add "look for the missing debris explosions" to make aunxx happy ;)


Top
 Profile  
 
 Post subject: R496 should now work
PostPosted: Thu Feb 22, 2007 8:29 am 
Offline
coder

Joined: Tue Nov 07, 2006 4:40 am
Posts: 236
I'm usually so careful, but as there's wasn't (as far as I knew) any functions within SaveGame.c it never ocured to me to check it. :(

At least we found it now rather than many more commits further down the line.

mostly rolled back the r493 changes, but kept part in place, and I'll look at depreciating most of the TreatAsUdword to correct this problem.

Aunxx


Top
 Profile  
 
 Post subject:
PostPosted: Thu Feb 22, 2007 4:39 pm 
Offline
coder

Joined: Mon Jan 29, 2007 2:45 pm
Posts: 61
Unfortunately the rollback resurrected the NIS cutting bug (17).


Top
 Profile  
 
 Post subject:
PostPosted: Fri Feb 23, 2007 2:16 am 
Offline
coder

Joined: Tue Nov 07, 2006 4:40 am
Posts: 236
Should be fixed in r498 again.
I did test it, but another pair of eyes can always help. :)

Aunxx.


Top
 Profile  
 
 Post subject:
PostPosted: Fri Feb 23, 2007 8:57 am 
Offline
Site Admin
User avatar

Joined: Tue Dec 14, 2004 12:41 am
Posts: 326
aunxx wrote:
Should be fixed in r498 again.
I did test it, but another pair of eyes can always help. :)


Eyes I gots... they just don't work ;)

But it sounds right again and I'll have Niece and Nephew check it when they can.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 6 posts ] 

All times are UTC - 5 hours


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group