Homesource Forums

Homeworld Source Editing Talk
It is currently Mon Sep 25, 2017 10:53 pm

All times are UTC - 5 hours




Post new topic Reply to topic  [ 8 posts ] 
Author Message
 Post subject: AVI movie playing patch
PostPosted: Tue Sep 25, 2007 4:59 pm 
Offline
coder
User avatar

Joined: Tue Dec 14, 2004 3:24 pm
Posts: 324
Location: UK (UTC+0)
A new contributor, Corey "bugfood" Hickey (forum account pending approval by zapkitty), sent me a patch "to make the end-of-game movie play":

Code:
Index: src/Game/KASFunc.c
===================================================================
--- src/Game/KASFunc.c   (revision 621)
+++ src/Game/KASFunc.c   (working copy)
@@ -125,7 +125,7 @@
         speechEventCleanup();
         singlePlayerMissionCompleteCB();

-        animBinkPlay(spGetCurrentMission(), spGetNextMission());
+        animAviPlay(spGetCurrentMission(), spGetNextMission());
     }
 }

Now it looks OK to me but I wanted to run it past the rest of you guys first because what I don't get is how the movies have otherwise been playing. Is there some other configuration mojo that can be done that circumvents the need for this change; is it only an issue with the final movie; or something else entirely?

Yours, confused and seeking enlightenment! :)

_________________
MacHomeworld | HomeworldSDL.org


Top
 Profile  
 
 Post subject:
PostPosted: Wed Sep 26, 2007 3:32 am 
Offline
coder
User avatar

Joined: Tue Dec 14, 2004 3:24 pm
Posts: 324
Location: UK (UTC+0)
It seems I've underestimated the level of cludge in the HW code :)

bugfood wrote:
All the other movies are played in src/Game/SinglePlayer.c (search for "animAviPlay"):

- the intro movie is played at the end of initialization
- all other movies are played during "hyperspace"

...however, there is no hyperspace at the end of the final level, so the end movie is played in the kasfMissionCompleted() function. My patch just replaces calling the old bink function; I'm guessing it was simply overlooked earlier.

_________________
MacHomeworld | HomeworldSDL.org


Top
 Profile  
 
 Post subject:
PostPosted: Wed Sep 26, 2007 4:14 am 
Offline
coder

Joined: Wed Nov 15, 2006 8:15 am
Posts: 100
Indeed, homeworld code is one piece of art! :)

The patch looks good to me and works without any problem.


Top
 Profile  
 
 Post subject:
PostPosted: Wed Sep 26, 2007 7:55 am 
Offline
coder

Joined: Tue Nov 07, 2006 4:40 am
Posts: 236
Greetings and salutations!

Yes, the Movie code is called during inital config, and then at the end of the ?horserace? (Been a while since I traced the origin of the calls) but it identifies all the movies by the current level and the next level.
The change is exactly what I'd of done, simple call the AVI instead of the BINK functions.
I'm really pleased the someone's managed to get through the game and tested all the movies. ( I hope :) )

I also really need to go back through the AVI code and tidy it up. The timing is still performed with a bit of string. :)

Aunxx.

PS. Long time no see lmop. Keeping well I hope? :)


Top
 Profile  
 
PostPosted: Wed Sep 26, 2007 12:46 pm 
Offline
Site Admin
User avatar

Joined: Tue Dec 14, 2004 12:41 am
Posts: 326
... so if they'll register again I'll take care of it.

!!!!!!!LMOP!!!!!!!!

... what?...

... oh...


Top
 Profile  
 
 Post subject:
PostPosted: Fri Sep 28, 2007 11:23 pm 
Offline

Joined: Wed Sep 26, 2007 1:40 pm
Posts: 2
aunxx wrote:
I'm really pleased the someone's managed to get through the game and tested all the movies. ( I hope :) )

I have indeed. :)
aunxx wrote:
I also really need to go back through the AVI code and tidy it up. The timing is still performed with a bit of string. :)

I did notice that the final movie seems to end before it should--that or the speech takes longer than it should. Either way, the movie ends and the speech fades out before it's finished.

I checked the length of the AVI file, outside of Homeworld, by playing it at the same time as the Bink file. They both stayed nearly synchronized and ended at the same time, so it doesn't seem to be a fault of the AVI file. I don't know where to investigate further.


Top
 Profile  
 
PostPosted: Mon Aug 05, 2013 3:39 am 
Offline

Joined: Wed Sep 26, 2007 1:40 pm
Posts: 2
suman wrote:
The repository is available and I'm committing all my backed up code. The mailing list still appears to be broken. I'm moving to a new host in order to attempt to fix this, since I'm not getting the support I need from my current host. There may be an associated outage for that but I'll give everyone a heads up when that happens.

I don't know if this update was specifically intended for this thread, but the patch in question was applied as r622, in case there was any ambiguity there.

Thanks,
Corey


Top
 Profile  
 
PostPosted: Thu Oct 17, 2013 7:28 am 
Offline
Site Admin
User avatar

Joined: Tue Dec 14, 2004 12:41 am
Posts: 326
bugfood wrote:
suman wrote:
spam deleted

I don't know if this update was specifically intended for this thread, but the patch in question was applied as r622, in case there was any ambiguity there.

Thanks,
Corey


Just a spammer.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 8 posts ] 

All times are UTC - 5 hours


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group