Homesource Forums

Homeworld Source Editing Talk
It is currently Mon Sep 25, 2017 10:53 pm

All times are UTC - 5 hours




Post new topic Reply to topic  [ 6 posts ] 
Author Message
 Post subject: Another patch
PostPosted: Tue Jul 22, 2008 12:07 am 
Offline

Joined: Mon Jul 07, 2008 6:24 pm
Posts: 14
I'm declaring my replacement sound code done (for now), there's three effect functions that are referenced still unimplemented, but nothing in the first couple of missions uses them. I'd post the patch inline, but it's 832 lines. ;)

I got write access to svn the other day, but I'm not sure if I can just commit anything, or if it has to get approved first. :)

edit: attaching files doesn't seem to work either...


Top
 Profile  
 
 Post subject: Re: Another patch
PostPosted: Tue Jul 22, 2008 2:52 am 
Offline
coder
User avatar

Joined: Tue Dec 14, 2004 3:24 pm
Posts: 324
Location: UK (UTC+0)
You can commit directly. You don't really need approval but if you're going to fundamentally alter how something works then it's good form to get a second opinion, particularly as it may have consequences for other platforms. :D

_________________
MacHomeworld | HomeworldSDL.org


Top
 Profile  
 
 Post subject: Re: Another patch
PostPosted: Tue Jul 22, 2008 3:09 am 
Offline

Joined: Mon Jul 07, 2008 6:24 pm
Posts: 14
New sound code committed. :)

The end result on x86 should be the same (sound works), and if for some reason it isn't, ./configure --enable-oldsound

This is probably of more interest to people porting to other platforms. ;)


Top
 Profile  
 
 Post subject: Re: Another patch
PostPosted: Tue Jul 22, 2008 3:29 am 
Offline
coder

Joined: Wed Nov 15, 2006 8:15 am
Posts: 100
I've trying your new code, seems to work as before, but without the crackling noise!!! ;)

Really good job, keep up the good work. The Mac platform has no sound, so it should not be a problem for lmop.
Concerning the Win32 port, we've got no news from nova, so, if it does not, he will complain! ;)


Top
 Profile  
 
 Post subject: Re: Another patch
PostPosted: Tue Jul 22, 2008 4:08 am 
Offline

Joined: Mon Jul 07, 2008 6:24 pm
Posts: 14
This is in addition to the patches in the other thread, and adds (hopefully) cross platform sound code.

Assuming no endian issues, the new files (fquant.c, fqcodec.c, fqeffect.c, dct.c) just need adding to the OSX build to add sound support.

For Windows, the build files will also need modifying to use the new code if desired (probably of little interest atm, HWSDL isn't 64bit safe yet).

I've already modified the Linux build files, as that's what I'm using, which might benefit a few people (anyone want to play Homeworld in Linux with sound on a non-x86 32bit platform?) :)

This is probably of most interest to people running OSX on a 32bit CPU right now, but also means potential 64bit ports will have sound support. ;)


Top
 Profile  
 
 Post subject: Re: Another patch
PostPosted: Mon Aug 04, 2008 11:17 am 
Offline
coder

Joined: Mon Jan 29, 2007 2:45 pm
Posts: 61
Nice job - getting rid of src/obj is good. I do seem to hear a bit more distortion with the new sound code though.

I wonder whether it would make sense to switch to OpenAL for the effects.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 6 posts ] 

All times are UTC - 5 hours


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group